Add support for PostgreSQL #21
Merged
+3,515
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… developer dependencies
Pin project dependencies to a set known to work using package-lock.json.
Support loading mappings from PostgreSQL via the `pg-native` library.
|
galaxyproject/galaxy#18481 got merged, this PR would be the next step. From Git blame, it looks like the original maintainer was @jmchilton. @jmchilton are you still a contact person for this repository? Who should I contact otherwise? |
mvdbeek
reviewed
Oct 4, 2024
lib/mapper.js
Outdated
| var postgresClient = require("pg-native"); | ||
| var watchFile = require("node-watch"); | ||
|
|
||
| var startsWith = function (subjectString, searchString) { |
There was a problem hiding this comment.
Why are we re-implementing startsWith and endsWith ?
There was a problem hiding this comment.
Nonsense, I agree. Changed to built-in JavaScript methods in 80183d2.
…n String prototype
|
@mvdbeek Sorry for not answering earlier, I was out of office. Thanks for the review. I do not have permission to merge PRs to this repository. Could you merge it, then #22 to bump the version number and finally create a new tag |
|
Thanks @natefoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading mappings from PostgreSQL via the
pg-nativelibrary. A major problem was that the proxy works watching files for changes (SQLite or JSON files). With PostgreSQL this is not possible, so I resorted to polling at regular intervals (configurable via the new--pollingIntervalcommand line option) and PostgreSQL asynchronous notifications. See the new functionwatchPostgresand new section of the README for more details.As a side effect, running the proxy requires nodejs v14 now. I have also included a package-lock.json file and version specifiers for
axios,axios-retry,chaiandmocha.This feature is meant to work in conjunction with galaxyproject/galaxy#18481.